fixed the greying image issue that occurs after uploading jpg image #2603 #2894
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if there are any unintended consequences from applying the entire desktop The part that we need is: p5.js-web-editor/client/styles/components/_editor.scss Lines 378 to 380 in 25067be The part that I'm concerned about is: p5.js-web-editor/client/styles/components/_editor.scss Lines 371 to 377 in 25067be |
|
Thanks for your work on this! I don't think this solution succinctly addresses the issue here, so I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to create another PR with an updated solution or check out our other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue-number
Changes: This will fix the error of resizing the window uploaded image gets greyed out and shifts to bottom #2603
I have verified that this pull request:
has no linting errors (npm run lint)
has no test errors (npm run test)
is from a uniquely-named feature branch and is up to date with the develop branch.
is descriptively named and links to an issue number, i.e. Fixes #2603