Skip to content

Fix assets tab partially active #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PiyushChandra17
Copy link
Contributor

Fixes #2682

Changes:

  • Added pointer-events: none
assets-atb.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@raclim
Copy link
Collaborator

raclim commented Jun 21, 2024

Thanks for your work on this!

I don't think this is the correct solution here because although it addresses the issue of the "Assets" tab being highlighted, for me, adding pointer-events: none makes all 3 of the tabs completely inaccessible on the mobile experience.

@raclim
Copy link
Collaborator

raclim commented Jun 25, 2024

Due to the current PR queue we have at the moment I'm going to close this one for now, but please feel free to reopen this one with any updates! Thank you again!

@raclim raclim closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mWeb(Safari) - Clicking on my stuff makes assets tab partially active
2 participants