Skip to content

Search For Canvases Under User-Supplied DOM Node #3530

Open
@twavv

Description

@twavv

This is causing some issues in a project where we use IFrames and share some libraries between them (explicitly, JuliaGizmos/WebIO.jl#225 is where I lay out the issues we're facing).

Essentially, I'd like to change this line

var canvases = document.getElementsByTagName('canvas');

to be something more like

    var dom = this._userNode || document;
    var canvases = dom.getElementsByTagName('canvas');

I can open up a PR if you'd accept it but I wanted to hear back first.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions