Skip to content

[p5.js 2.0 Bug Report]: parameters for model should be updated to include count #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 17 tasks
lukeplowden opened this issue May 19, 2025 · 2 comments
Closed
1 of 17 tasks
Assignees
Milestone

Comments

@lukeplowden
Copy link
Member

lukeplowden commented May 19, 2025

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

p5.js version

v2.0.2

Web browser and version

n/a

Operating system

n/a

Steps to reproduce this

Steps:

  1. Call model(myModel, 1) where the second parameter is correctly an instance count

Currently, the parameterData.json and the YUIDocs for model() in loading.js do not reflect the ability to add an instance count for custom instancing shaders. I noticed this whilst working on the p5.strands tutorial. I have fixed this on my local branch, by updating the two files above. This gives us a false negative when using the instance count.

Copy link

welcome bot commented May 19, 2025

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

@ksen0
Copy link
Member

ksen0 commented May 19, 2025

Thanks for working on this @lukeplowden !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

3 participants