Skip to content

add MiterLimits() #6331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add MiterLimits() #6331

wants to merge 1 commit into from

Conversation

munusshih
Copy link
Contributor

@munusshih munusshih commented Aug 7, 2023

Resolves #[Add issue number here]

Changes:

  • Add function miterLimit()
  • Add its documentation

Screenshots of the change:

PR Checklist

@davepagurek
Copy link
Contributor

There's also a currently hardcoded miter limit in WebGL here:

float maxMag = 3. * uStrokeWeight;

It would be great to eventually replace that with the same limit as in 2D mode, probably by passing the value in as a shader uniform. Doesn't need to be part of this PR necessarily, though -- maybe just file an issue for it so we can remember to add it to WebGL too later?

@Qianqianye
Copy link
Contributor

Thanks @munusshih for working on it and @limzykenneth @davepagurek for reviewing. Just following up on this PR, is there a plan to get this PR merged soon, @munusshih? Please let us know if you need any support from us and the GSoC mentors @kyeah @aahdee.

@munusshih munusshih marked this pull request as ready for review September 1, 2023 02:51
@munusshih
Copy link
Contributor Author

Yes. I think this is ready for review.

@Qianqianye
Copy link
Contributor

Thanks @munusshih. Tagging mentors and advisors to review this @aahdee @kyeah @limzykenneth

@munusshih munusshih mentioned this pull request Sep 4, 2023
17 tasks
@Qianqianye Qianqianye requested a review from dhowe September 5, 2023 20:05
@limzykenneth
Copy link
Member

@munusshih I'm seeing an error with FES when trying to use miterLimit():

Uncaught TypeError: queryResult is undefined

The unit test are not passing as well with:

TypeError: this._renderer.miterLimit is not a function
      at _main.default.miterLimit (http://localhost:9001/lib/p5.js:68394:26)

Can you have a look, the problem is likely that the miterLimit function is only registered in p5.renderer2D and not p5.renderer.

@dhowe
Copy link
Contributor

dhowe commented Nov 10, 2024

whats the status on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants