-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
add MiterLimits() #6331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add MiterLimits() #6331
Conversation
There's also a currently hardcoded miter limit in WebGL here: p5.js/src/webgl/shaders/line.vert Line 185 in c06e12a
It would be great to eventually replace that with the same limit as in 2D mode, probably by passing the value in as a shader uniform. Doesn't need to be part of this PR necessarily, though -- maybe just file an issue for it so we can remember to add it to WebGL too later? |
Thanks @munusshih for working on it and @limzykenneth @davepagurek for reviewing. Just following up on this PR, is there a plan to get this PR merged soon, @munusshih? Please let us know if you need any support from us and the GSoC mentors @kyeah @aahdee. |
Yes. I think this is ready for review. |
Thanks @munusshih. Tagging mentors and advisors to review this @aahdee @kyeah @limzykenneth |
@munusshih I'm seeing an error with FES when trying to use
The unit test are not passing as well with:
Can you have a look, the problem is likely that the |
whats the status on this ? |
Resolves #[Add issue number here]
Changes:
Screenshots of the change:
PR Checklist
npm run lint
passes