Revamped config.yml(branch:main) #7775
Conversation
Signed-off-by: shiva <shiva_05@outlook.com>
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
| Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you! | ||
| Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. | ||
|
|
||
| For guidance on contributing, check out our [contributing guidelines](https://github.com/processing/p5.js/blob/main/CONTRIBUTING.md). |
There was a problem hiding this comment.
Please link this to https://p5js.org/contribute/ instead (this is where the main contributor docs are built and deployed on release):
For guidance on contributing, check out our contributor guidelines and other resources for contributors!
|
|
||
| 📜 Please also review our [Code of Conduct](https://p5js.org/code-of-conduct/) to understand our community standards. | ||
|
|
||
| 🌟 You can Also check out our [Contribute page](https://p5js.org/contribute/) to learn more ways to get involved! |
There was a problem hiding this comment.
I think this line (15) can be removed, as the contribution guidelines are linked above.
|
|
||
| 🌟 You can Also check out our [Contribute page](https://p5js.org/contribute/) to learn more ways to get involved! | ||
|
|
||
| Thank You! | ||
| # Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome | ||
|
|
||
| # Comment to be posted to on PRs from first time contributors in your repository | ||
| newPRWelcomeComment: > | ||
| 🎉 Thanks for opening this pull request! Please check out our [contributing guidelines](https://github.com/processing/p5.js/blob/main/CONTRIBUTING.md) if you haven't already. And be sure to add yourself to the [list of contributors on the readme page](https://github.com/processing/p5.js#contributors)! |
There was a problem hiding this comment.
Actually, I think your text above is more helpful :) So I'd suggest updating the line 22 in your file:
🎉 Thanks for opening this pull request! For guidance on contributing, check out our [contributor guidelines](https://p5js.org/contribute/contributor_guidelines/) and other [resources for contributors](https://p5js.org/contribute)!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to [add yourself](https://github.com/processing/p5.js/issues/2309) to the [list of contributors on the readme page](https://github.com/processing/p5.js#contributors) !
|
|
||
| 📜 Please also review our [Code of Conduct](https://p5js.org/code-of-conduct/) to understand our community standards. | ||
|
|
||
| 🌟 You can Also check out our [Contribute page](https://p5js.org/contribute/) to learn more ways to get involved! |
There was a problem hiding this comment.
Same as above - I think this can be removed
There was a problem hiding this comment.
Everything looks good on my end. Also, @ksen0, thank you so much for your thoughtful review, these are great. Once the suggested changes are addressed, I believe this PR will be good to merge.
|
|
||
| For guidance on contributing, check out our [contributing guidelines](https://github.com/processing/p5.js/blob/main/CONTRIBUTING.md). | ||
|
|
||
| 💬 If you have questions or need support, feel free to join the [Processing Foundation Forum](https://discourse.processing.org/) or visit our [Community page](https://p5js.org/community/). |
There was a problem hiding this comment.
| 💬 If you have questions or need support, feel free to join the [Processing Foundation Forum](https://discourse.processing.org/) or visit our [Community page](https://p5js.org/community/). | |
| 💬 If you have questions or need support, feel free to join the [Processing Foundation Forum](https://discourse.processing.org/) or visit our [Community page](https://p5js.org/community/). |
I think we have an extra space here!
Related to processing/p5.js-website#817
Changes:
.github/config.ymlScreenshots of the change:
NA
PR Checklist
npm run lintpasses