Support ebc for kv zch #3106
Closed
Support ebc for kv zch #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76636927 |
|
This pull request was exported from Phabricator. Differential Revision: D76636927 |
EddyLXJ
added a commit
to EddyLXJ/torchrec
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: pytorch#3106 # Change logs 1. add ZeroCollisionKeyValueEmbeddingBag emb lookup 2. address existing unit test missing for ebc ssd offloading 3. add new ut for kv zch embedding bag module Embedding bag update is same as embedding update. Details can be found in D73567631 Differential Revision: D76636927
EddyLXJ
force-pushed
the
export-D76636927
branch
from
8447505 to
b3622b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76636927 |
EddyLXJ
added a commit
to EddyLXJ/torchrec
that referenced
this pull request
Jun 18, 2025
Summary: Pull Request resolved: pytorch#3106 # Change logs 1. add ZeroCollisionKeyValueEmbeddingBag emb lookup 2. address existing unit test missing for ebc ssd offloading 3. add new ut for kv zch embedding bag module Embedding bag update is same as embedding update. Details can be found in D73567631 Reviewed By: duduyi2013 Differential Revision: D76636927
EddyLXJ
force-pushed
the
export-D76636927
branch
from
b3622b7 to
d810c8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76636927 |
EddyLXJ
added a commit
to EddyLXJ/torchrec
that referenced
this pull request
Jun 18, 2025
Summary: Pull Request resolved: pytorch#3106 # Change logs 1. add ZeroCollisionKeyValueEmbeddingBag emb lookup 2. address existing unit test missing for ebc ssd offloading 3. add new ut for kv zch embedding bag module Embedding bag update is same as embedding update. Details can be found in D73567631 Reviewed By: duduyi2013 Differential Revision: D76636927
EddyLXJ
force-pushed
the
export-D76636927
branch
from
d810c8b to
9373f9d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76636927 |
EddyLXJ
added a commit
to EddyLXJ/torchrec
that referenced
this pull request
Jun 18, 2025
Summary: Pull Request resolved: pytorch#3106 # Change logs 1. add ZeroCollisionKeyValueEmbeddingBag emb lookup 2. address existing unit test missing for ebc ssd offloading 3. add new ut for kv zch embedding bag module Embedding bag update is same as embedding update. Details can be found in D73567631 Reviewed By: duduyi2013 Differential Revision: D76636927
EddyLXJ
force-pushed
the
export-D76636927
branch
from
9373f9d to
3bdca06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76636927 |
EddyLXJ
added a commit
to EddyLXJ/torchrec
that referenced
this pull request
Jul 7, 2025
Summary: # Change logs 1. add ZeroCollisionKeyValueEmbeddingBag emb lookup 2. address existing unit test missing for ebc ssd offloading 3. add new ut for kv zch embedding bag module Embedding bag update is same as embedding update. Details can be found in D73567631 Reviewed By: duduyi2013, kausv Differential Revision: D76636927
Summary: # Change logs 1. add ZeroCollisionKeyValueEmbeddingBag emb lookup 2. address existing unit test missing for ebc ssd offloading 3. add new ut for kv zch embedding bag module Embedding bag update is same as embedding update. Details can be found in D73567631 Reviewed By: duduyi2013, kausv Differential Revision: D76636927
|
This pull request was exported from Phabricator. Differential Revision: D76636927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D76636927