-
Notifications
You must be signed in to change notification settings - Fork 174
fix: e-Invoice and e-Waybill Standard APIs #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Connected to Huly®: IC-3328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with the e-Invoice and e-Waybill Standard APIs by updating API endpoints, renaming classes for clarity, and enhancing authentication and encryption flows.
- Renames PublicCertificate to StaticResourcesAPI and updates corresponding API endpoints and response handling.
- Standardizes BASE_PATH values and adjusts authentication flows in both e-Waybill and e-Invoice APIs.
- Enhances encryption/decryption logic and updates sandbox credential handling.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
india_compliance/gst_india/api_classes/taxpayer_base.py | Renamed class and updated endpoint and response message handling for public certificates. |
india_compliance/gst_india/api_classes/e_waybill.py | Updated BASE_PATH values, added decorator for base path changes, and modified authentication/encryption logic. |
india_compliance/gst_india/api_classes/e_invoice.py | Adjusted BASE_PATH, refined encryption/decryption of API requests/responses, and updated sandbox handling. |
Files not reviewed (1)
- india_compliance/gst_india/doctype/gst_settings/gst_settings.json: Language not supported
Comments suppressed due to low confidence (1)
india_compliance/gst_india/api_classes/taxpayer_base.py:59
- There is a return value inconsistency: the method compares and stores response.message but returns response.certificate. It is recommended to return response.message to align with the updated logic.
return response.certificate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3199 +/- ##
===========================================
- Coverage 59.70% 59.32% -0.38%
===========================================
Files 133 133
Lines 13428 13707 +279
===========================================
+ Hits 8017 8132 +115
- Misses 5411 5575 +164
🚀 New features to boost your workflow:
|
Closes: #2459