Skip to content

fix: e-Invoice and e-Waybill Standard APIs #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

vishakhdesai
Copy link
Contributor

@vishakhdesai vishakhdesai commented Mar 11, 2025

Closes: #2459

Copy link

Connected to Huly®: IC-3328

@vishakhdesai vishakhdesai marked this pull request as ready for review March 13, 2025 08:50
@vorasmit vorasmit requested a review from Copilot March 31, 2025 13:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with the e-Invoice and e-Waybill Standard APIs by updating API endpoints, renaming classes for clarity, and enhancing authentication and encryption flows.

  • Renames PublicCertificate to StaticResourcesAPI and updates corresponding API endpoints and response handling.
  • Standardizes BASE_PATH values and adjusts authentication flows in both e-Waybill and e-Invoice APIs.
  • Enhances encryption/decryption logic and updates sandbox credential handling.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
india_compliance/gst_india/api_classes/taxpayer_base.py Renamed class and updated endpoint and response message handling for public certificates.
india_compliance/gst_india/api_classes/e_waybill.py Updated BASE_PATH values, added decorator for base path changes, and modified authentication/encryption logic.
india_compliance/gst_india/api_classes/e_invoice.py Adjusted BASE_PATH, refined encryption/decryption of API requests/responses, and updated sandbox handling.
Files not reviewed (1)
  • india_compliance/gst_india/doctype/gst_settings/gst_settings.json: Language not supported
Comments suppressed due to low confidence (1)

india_compliance/gst_india/api_classes/taxpayer_base.py:59

  • There is a return value inconsistency: the method compares and stores response.message but returns response.certificate. It is recommended to return response.message to align with the updated logic.
return response.certificate

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 38.36858% with 204 lines in your changes missing coverage. Please review.

Project coverage is 59.32%. Comparing base (9dc4876) to head (f6e6358).
Report is 51 commits behind head on develop.

Files with missing lines Patch % Lines
...ndia_compliance/gst_india/api_classes/e_invoice.py 37.43% 112 Missing ⚠️
...ndia_compliance/gst_india/api_classes/e_waybill.py 41.08% 76 Missing ⚠️
..._compliance/gst_india/api_classes/taxpayer_base.py 15.38% 11 Missing ⚠️
india_compliance/gst_india/api_classes/base.py 50.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3199      +/-   ##
===========================================
- Coverage    59.70%   59.32%   -0.38%     
===========================================
  Files          133      133              
  Lines        13428    13707     +279     
===========================================
+ Hits          8017     8132     +115     
- Misses        5411     5575     +164     
Files with missing lines Coverage Δ
india_compliance/gst_india/api_classes/base.py 77.07% <50.00%> (-1.85%) ⬇️
..._compliance/gst_india/api_classes/taxpayer_base.py 24.18% <15.38%> (-0.19%) ⬇️
...ndia_compliance/gst_india/api_classes/e_waybill.py 47.50% <41.08%> (-27.05%) ⬇️
...ndia_compliance/gst_india/api_classes/e_invoice.py 44.28% <37.43%> (-38.77%) ⬇️

... and 21 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Standard APIs for e-Invoice and e-Waybill
2 participants