Added social share options and open graph tags #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the default admin credentials to match what is stated in the Readme
This reverts commit b0b096a.
This adds social sharing options to blog post pages and also includes graph meta tags to ensure posts are shared properly. Specifically: - Added social media icons (Facebook, Twitter, Linkedin) - Implemented proper sharing to each platform (Share url and meta tags) - Split blog base from website base so it is easier to add blog specific SEO tags - Added open graph tags to main website base by extension This PR closes #23
Merge branch 'develop' into feature/yo/23-social-share-options
mazma1
reviewed
Dec 24, 2019
There was a problem hiding this comment.
Nice work Yemisi, and I apologize for the very late review.
One observation, the circle border of the icons look a bit skewed. I added a couple of styles and got something smoother, you can try them out.
-
Gave
social-share-icona uniform height to make it a square:
.social-share-icon { height: 50px; } -
Threw in a little padding to the icon:
.fa { padding-top: 15px; } -
The result I got:
mazma1
reviewed
Dec 24, 2019
|
Thank you for the suggestions @mazma1, I will try them out and update the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added social share options to the blog post page and also open graph tags to ensure shared posts and URLs are displayed properly on social media sites
Desktop view
Mobile view
