docs: update example code #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove type annotation from preview.js example solved: storybookjs#81
|
Wouldn't it be better to treat the file as TypeScript, and change the extension to |
|
Yes, it is a good idea. Let me update it. |
|
I don't have a strong opinion, but it doesn't seem worth cluttering the README with two different file formats. Ideally it would be consistent and only use one type, either JS or TS, and personally I'd advocate for TS. But I'm not really maintaining this addon, so feel free to decide however you'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove type annotation from preview.js example
solved: #81