Skip to content

android: be stricter about system backups #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasmz-dev
Copy link

we should also exclude D2D because it also does not work and results in a broken state

Copy link

review-ai-agent bot commented May 25, 2025

Pull Request Revisions

RevisionDescription
r7
Added backup rules for AndroidIntroduced backup rules XML for Android to prevent system backups and data extraction across different Android versions
r6No changes since last revision
r5No changes since last revision
r4
Added data extraction rules configIntroduced data_extraction_rules.xml in Android manifest to exclude various data domains from cloud backup and device transfer
r3
Fixed spacing in XML data extractionRemoved extra whitespace between "external" and "path" attributes in data extraction rules XML
r2
Data extraction rules file updatedRemoved extra whitespace in data extraction rules XML file, maintaining existing exclusion configuration
r1
Added data extraction rules XMLAdded Android data extraction rules to prevent backup and transfer of app data across domains

☑️ AI review skipped after 5 revisions, comment with `/review` to review again
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

@lucasmz-dev lucasmz-dev force-pushed the dont-allow-system-backups branch from 6af92c8 to 0bfb0d5 Compare May 25, 2025 11:48
@lucasmz-dev lucasmz-dev force-pushed the dont-allow-system-backups branch 4 times, most recently from 829ba03 to f42187e Compare May 31, 2025 17:26
we should also exclude D2D because it results in a broken store probably due to KeyStore

Fixes #tailscale/tailscale#732

Signed-off-by: LucasMZ <git@lucasmz.dev>
@lucasmz-dev lucasmz-dev force-pushed the dont-allow-system-backups branch from f42187e to 0dec9c9 Compare May 31, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant