-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(server): comment service and resolver #12761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 06-09-feat_server_comment_model
Are you sure you want to change the base?
feat(server): comment service and resolver #12761
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 06-09-feat_server_comment_model #12761 +/- ##
===================================================================
+ Coverage 55.20% 55.60% +0.40%
===================================================================
Files 2640 2658 +18
Lines 125274 126756 +1482
Branches 19827 19950 +123
===================================================================
+ Hits 69156 70489 +1333
- Misses 53926 53958 +32
- Partials 2192 2309 +117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c27c56e
to
eb80549
Compare
0cf5316
to
6037b1a
Compare
eb80549
to
1a2f939
Compare
6037b1a
to
5b63eaa
Compare
1a2f939
to
17a8df8
Compare
b40d957
to
efd45a1
Compare
17a8df8
to
9281a23
Compare
fe78f84
to
b260643
Compare
@@ -5,6 +5,7 @@ export enum DocRole { | |||
None = -(1 << 15), | |||
External = 0, | |||
Reader = 10, | |||
Commenter = 15, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
team workspace default role should change to Commenter? or keep Reader
9281a23
to
a78e5e4
Compare
b260643
to
c763af7
Compare
a78e5e4
to
26516cd
Compare
c763af7
to
784dae5
Compare
26516cd
to
afbdd9a
Compare
784dae5
to
db96780
Compare
close CLOUD-227
PR Dependency Tree
This tree was auto-generated by Charcoal