Skip to content

feat(server): comment service and resolver #12761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 06-09-feat_server_comment_model
Choose a base branch
from

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 9, 2025

Copy link

coderabbitai bot commented Jun 9, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added mod:i18n Related to i18n app:server test Related to test cases labels Jun 9, 2025
Copy link
Member Author

fengmk2 commented Jun 9, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 95.27121% with 34 lines in your changes missing coverage. Please review.

Project coverage is 55.60%. Comparing base (afbdd9a) to head (db96780).

Files with missing lines Patch % Lines
...ckages/backend/server/src/core/comment/resolver.ts 92.45% 24 Missing ⚠️
packages/backend/server/src/core/comment/types.ts 95.33% 9 Missing ⚠️
...ackages/backend/server/src/core/comment/service.ts 99.28% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           06-09-feat_server_comment_model   #12761      +/-   ##
===================================================================
+ Coverage                            55.20%   55.60%   +0.40%     
===================================================================
  Files                                 2640     2658      +18     
  Lines                               125274   126756    +1482     
  Branches                             19827    19950     +123     
===================================================================
+ Hits                                 69156    70489    +1333     
- Misses                               53926    53958      +32     
- Partials                              2192     2309     +117     
Flag Coverage Δ
server-test 78.40% <95.27%> (-0.61%) ⬇️
unittest 31.60% <ø> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_model branch from c27c56e to eb80549 Compare June 9, 2025 06:40
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_service_and_resolver branch from 0cf5316 to 6037b1a Compare June 9, 2025 06:40
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_model branch from eb80549 to 1a2f939 Compare June 10, 2025 12:24
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_service_and_resolver branch from 6037b1a to 5b63eaa Compare June 10, 2025 12:25
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_model branch from 1a2f939 to 17a8df8 Compare June 10, 2025 12:29
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_service_and_resolver branch 3 times, most recently from b40d957 to efd45a1 Compare June 11, 2025 03:41
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_model branch from 17a8df8 to 9281a23 Compare June 11, 2025 08:46
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_service_and_resolver branch from fe78f84 to b260643 Compare June 11, 2025 08:46
@@ -5,6 +5,7 @@ export enum DocRole {
None = -(1 << 15),
External = 0,
Reader = 10,
Commenter = 15,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team workspace default role should change to Commenter? or keep Reader

@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_model branch from 9281a23 to a78e5e4 Compare June 12, 2025 05:25
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_service_and_resolver branch from b260643 to c763af7 Compare June 12, 2025 05:25
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_model branch from a78e5e4 to 26516cd Compare June 13, 2025 10:38
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_service_and_resolver branch from c763af7 to 784dae5 Compare June 13, 2025 10:39
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_model branch from 26516cd to afbdd9a Compare June 17, 2025 07:59
@fengmk2 fengmk2 force-pushed the 06-09-feat_server_comment_service_and_resolver branch from 784dae5 to db96780 Compare June 17, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server mod:i18n Related to i18n test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant