Skip to content

Conversation

taokeqin
Copy link

Background

Summary

Verification

Tasks

  • Tests have been added / updated (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • A patch changeset for relevant packages has been added (for bug fixes / features - run pnpm changeset in the project root)
  • Formatting issues have been fixed (run pnpm prettier-fix in the project root)

Future Work

Related Issues

@lgrammel
Copy link
Collaborator

hi can you rebase against latest main?

@taokeqin
Copy link
Author

hi can you rebase against latest main?

done.

@nicoalbanese
Copy link
Collaborator

nicoalbanese commented Jul 11, 2025

The current wording is intended as it forces the model to make two tools calls.

@taokeqin
Copy link
Author

Hi @nicoalbanese, yes, we can close this.
You’re right — based on the current code, the wording is correct.
The code example was changed in this commit:
26c4086

My changes were made before that change was introduced, so at the time, the wording was still incorrect.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants