fix(ssr): handle initial selected state for select with v-model + v-for/v-if option #13487
+140
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe update enhances SSR code generation for Changes
Sequence Diagram(s)sequenceDiagram
participant Template as Template AST
participant SSRTransform as SSR VModel Transform
participant SSRCode as SSR Codegen
Template->>SSRTransform: Encounter <select multiple v-model>
SSRTransform->>SSRTransform: Find <optgroup> with children
loop For each child in <optgroup>
alt Element node
SSRTransform->>SSRTransform: processOption(child)
else FOR node
SSRTransform->>SSRTransform: For each FOR child, processOption(child)
else IF node
SSRTransform->>SSRTransform: For each IF branch, processOption(branch child)
end
end
SSRTransform->>SSRCode: Generate SSR code with correct selected attribute logic
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/compiler-ssr/src/transforms/ssrVModel.ts (1)
68-78: Duplicate traversal logic – consider extracting a shared helperThe new block repeats almost exactly the traversal logic that already exists in
processChildren(lines 174-185). Duplicating this walker increases maintenance cost and the risk of future divergence.A small refactor can DRY the code and keep the recursion rules in one place:
- } else if (plainNode.tag === 'optgroup') { - plainNode.children.forEach(option => { - if (option.type === NodeTypes.ELEMENT) { - processOption(option as PlainElementNode) - } else if (option.type === NodeTypes.FOR) { - option.children.forEach(c => processOption(c as PlainElementNode)) - } else if (option.type === NodeTypes.IF) { - option.branches.forEach(b => - b.children.forEach(c => processOption(c as PlainElementNode)), - ) - } - }) + } else if (plainNode.tag === 'optgroup') { + // re-use the generic walker so the traversal rules stay in one place + processChildren(plainNode.children) }That change would require hoisting
processChildrenoutside the<select>branch (or defining a module-level helper) but would eliminate the duplicate code and keep the traversal strategy consistent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/compiler-ssr/__tests__/ssrVModel.spec.ts(1 hunks)packages/compiler-ssr/src/transforms/ssrVModel.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules
- GitHub Check: Header rules
- GitHub Check: Pages changed
- GitHub Check: test / unit-test-windows
🔇 Additional comments (1)
packages/compiler-ssr/__tests__/ssrVModel.spec.ts (1)
170-225: 👍 Great addition of edge-case coverageThe two new cases (
v-forandv-ifinside<optgroup>) hit the exact scenarios the bug fix targets and safeguard against regressions. Snapshot assertions also verify thatselectedhandling and text interpolation remain correct.
edison1105
added
ready to merge
|
@skirtles-code Updated~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13486
Summary by CodeRabbit
Tests
<select multiple>elements with<optgroup>containing dynamic<option>elements usingv-forandv-ifdirectives.Bug Fixes
<optgroup>, ensuring correct handling of loops and conditionals during server-side rendering.