Skip to content

Replace incorrect "async iterable" token to "async_iterable" #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented May 19, 2025

This changes the async iterable grammar added by #1397 to async_iterable so that the grammar can stay within LL(1) rule.

Fixes #1490

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->


Preview (#Don't…) (<a href="https://whatpr.org/webidl/1489.html#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->


<a href="https://whatpr.org/webidl/1489.html" title="Last updated on Jun 8" title="#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->


#just…) (#2025) (Preview | Preview | #9:00…) (#2025) (Diff" title="#9:00 PM UTC (e2b04a8)">Diff">#9:00…) | Diff

@saschanaz
Copy link
Member Author

And this caught a grammar problem:

 The WebIDL grammar is NOT LL(1) due to the following conflicts:
    1. PartialInterfaceMember:
       * "async" (54/58)

Seems we should change the grammar?

@annevk
Copy link
Member

annevk commented May 20, 2025

How widely deployed is this type? I suspect not very if at all? I wouldn't mind making it async_iterable instead if that would help.

cc @lucacasonato

@saschanaz saschanaz changed the title Fix "async iterable" being a single token Replace incorrect "async iterable" token to "async_iterable" Jun 8, 2025
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschanaz
Copy link
Member Author

Added comments to the same bugs filed by #1397 as most of them are still open.

@saschanaz
Copy link
Member Author

widlparser merged the original PR and applied the grammar change, so bikeshed is good to go once they get the new dependency.

Do we have any other blockers here?

@domenic domenic merged commit d5cc64c into whatwg:main Jul 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The new async iterable type broke LL(1) rule
4 participants