Fix missing items in organization menu #33928
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
ExplodingDragon
changed the title
ExplodingDragon
force-pushed
the
fix-tmpl
branch
from
dfdebdd to
8da4b0d
Compare
wxiaoguang
reviewed
Mar 18, 2025
wxiaoguang
reviewed
Mar 18, 2025
|
|
pull-request-size
bot
added
size/M
wxiaoguang
reviewed
Mar 20, 2025
| ctx.ServerError("PrepareOrgHeader", err) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
Now the logic seems strange:
Ideally, maybe there should be a shared_user.PrepareOwnerHeader, and in it prepare for user or for org by user type?
There was a problem hiding this comment.
@wxiaoguang I will attempt to refactor this section and extract more common code.
|
Is this PR active? Maybe it's good to have it in 1.24, ps: a recent similar PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing items in organization menu.
Before:
After:
