Correctly handle submodule view and avoid throwing 500 error #34121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
|
Before the fix:
|
lunny
approved these changes
Apr 4, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Apr 6, 2025
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Gitea reports 500 error when viewing a submodule path directly.
After: auto-redirect for in-site links, and show 404 for external links (to avoid open redirect or phishing)
Actually such "submodule" link is never constructed by Gitea's code, just in case some end users manually construct that link.