-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: Workflow application node parameter saving cannot be reflected back #3019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this code snippet, there are several potential issues that need to be addressed:
Redundant Code: The same logic is repeated for
merge_api_input_field_list
andmerge_user_input_field_list
. Consider creating a helper function or refactor these sections.Undefined Old API Input Field List: If
old_api_input_field_list
can be undefined, it's good practice to handle that case properly.Type Annotations: Ensure type annotations are correct for variables used throughout the function.
String Literals: Replace hardcoded string literals with constants where applicable to improve readability.
Cloning Process: The use of
cloneDeep()
from lodash might not always be necessary. You could consider using simple deep cloning if you don't rely on specific features provided by lodash.Here's an optimized version of the code addressing some of these concerns:
By refactoring the code into reusable methods like
mergeFields
, we have reduced redundancy and improved maintainability. This approach also makes the code easier to test and understand.