-
Notifications
You must be signed in to change notification settings - Fork 573
Python 2 -> 3 part 1 #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 2 -> 3 part 1 #1746
Conversation
Not sure if I should remove check for python 3 in 7c66577 before everything works |
Otherwise I get this with python 3.8.7 when starting BM: TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' (assuming changes in Bitmessage#1746)
Maybe you begin with some tests? Separate It looks like in python3 you can reuse defaults from Porting |
Notice the required checks |
This reverts commit 7c66577.
Could work. I've started that in https://github.com/iljah/PyBitmessage/tree/py3-tests1 and once I get bit further I'll submit another pull request. |
After #1749 I start hitting errors that are fixed by stuff here so I guess I'll wait until this is merged until continuing work on above test fixes |
Few changes to support python 3. Supercedes #1745. Works with python 2.7.15 in fedora 29.