Skip to content

feat(genai): Add Initial Sample for Gen AI SDK #10039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

holtskinner
Copy link
Contributor

Description

Creates initial Text Generation sample for Java Gen AI SDK https://github.com/googleapis/java-genai/

@holtskinner holtskinner requested review from yoshi-approver and a team as code owners March 11, 2025 18:40
Copy link

snippet-bot bot commented Mar 11, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request introduces an initial sample for the Java Gen AI SDK, focusing on text generation. It includes a pom.xml file to manage dependencies, a TextgenWithTxt.java file containing the code sample for text generation, and a TextGenerationIT.java file for integration testing.

Highlights

  • Dependency Management: The pom.xml file sets up the project with necessary dependencies, including the google-genai library and testing frameworks like JUnit and Truth.
  • Text Generation Sample: The TextgenWithTxt.java file demonstrates how to use the Gen AI SDK to generate text from a prompt. It uses the gemini-2.0-flash-001 model to answer the question "How does AI work?".
  • Integration Testing: The TextGenerationIT.java file includes an integration test to verify that the text generation sample runs successfully and produces a non-empty response.

Changelog

Click here to see the changelog
  • genai/pom.xml
    • Added the pom.xml file to manage project dependencies.
    • Included dependencies for google-genai, JUnit, and Truth.
    • Configured the project to use Java 1.8.
  • genai/src/main/java/genai/text_generation/TextgenWithTxt.java
    • Created the TextgenWithTxt.java file to demonstrate text generation using the Gen AI SDK.
    • Used the Client class to interact with the Gen AI service.
    • Generated text using the gemini-2.0-flash-001 model with the prompt "How does AI work?".
  • genai/src/test/java/genai/text_generation/TextGenerationIT.java
    • Added the TextGenerationIT.java file for integration testing.
    • Included a test case testTextgenWithTxt to verify the text generation sample.
    • Asserted that the output of the text generation sample is not empty.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A spark of code, a gentle start,
GenAI whispers, playing its part.
With models trained and prompts so keen,
A world of text, a vibrant scene.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a basic text generation sample using the Java Gen AI SDK. The code is straightforward and easy to understand. However, there are a few issues that need to be addressed before merging.

Summary of Findings

  • Copyright Year: The copyright year in the source files is set to 2025. Please confirm that this is the correct year, or if it should be updated to the current year.
  • Missing API Key: The code does not include any mechanism for passing the API key to the GenAI client. This will cause the program to fail. Please add a way to pass the API key to the client.
  • Exception Handling: The code throws IOException and HttpException, but doesn't handle them properly. It's important to catch these exceptions and handle them gracefully, or re-throw them with a more specific exception type.

Merge Readiness

The pull request is not ready to be merged. The copyright year needs to be confirmed, the API key needs to be passed to the client, and the exceptions need to be handled properly. I am unable to approve this pull request, and recommend that it not be merged until these issues are addressed, and that others review and approve this code before merging.

@telpirion telpirion changed the title docs(genai): Add Initial Sample for Gen AI SDK feat(genai): Add Initial Sample for Gen AI SDK Mar 24, 2025
@telpirion
Copy link
Contributor

From a style perspective, this looks fine to me. Looks like there are some CI/CD failures that need to be addressed.

@telpirion telpirion self-assigned this Apr 9, 2025
@telpirion
Copy link
Contributor

@holtskinner do you intend to return to this PR?

@telpirion
Copy link
Contributor

Since there hasn't been any movement on this PR in two months, I'm going to close. Please reopen when you are ready to work on it. Thanks!

@telpirion telpirion closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants