Skip to content

Add Path tool support for Alt-dragging an anchor to pull out a fresh equidistant handle pair #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 17, 2025

Conversation

4adex
Copy link
Contributor

@4adex 4adex commented Mar 28, 2025

Part of #1870

Path tool - When dragging an anchor:

  • Alt (new since video was recorded), if held during the start of the click-drag, converts the anchor's handles to colinear and drags the handle pair instead of the anchor, keeping them equidistant unless Alt is released to temporarily return the opposite handle back to where it started before the Alt-drag began (which involves returning its colinear state back to what it was before). Should work with Tab to swap which is the dragged handle, so its opposite can be the one that's returned if Alt is temporarily released. Just Alt clicking but not dragging the anchor should remove both handles by setting them to zero length.

@4adex 4adex marked this pull request as ready for review March 30, 2025 13:47
@Keavon
Copy link
Member

Keavon commented Mar 30, 2025

!build

Copy link

📦 Build Complete for 8bf80d7
https://3d1a4503.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 4, 2025

!build

Copy link

github-actions bot commented Apr 4, 2025

📦 Build Complete for b767dda
https://ec93348b.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 4, 2025

Screencast with updated requests: https://files.keavon.com/-/StingyFocusedXiphiasgladius/capture_3_.mp4

And let's be sure, using this discussed strategy, to avoid this from crossing like this: https://files.keavon.com/-/BitesizedMixedBasil/capture_85_.mp4

@Keavon Keavon marked this pull request as draft April 4, 2025 09:19
@Keavon Keavon changed the title Alt dragging from anchor using Path tool Make Path tool Alt-drag from an anchor drag out a fresh equidistant handle pair Apr 4, 2025
@Keavon Keavon force-pushed the master branch 3 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
@4adex 4adex marked this pull request as ready for review April 13, 2025 15:17
@Keavon
Copy link
Member

Keavon commented Apr 13, 2025

!build

Copy link

📦 Build Complete for f831f2b
https://6c56aca4.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 13, 2025

We need Alt-click (without drag) to collapse the handles to zero-length in the same way that double-clicking does. See the comparison:

capture_39_.mp4

@Keavon Keavon changed the title Make Path tool Alt-drag from an anchor drag out a fresh equidistant handle pair Add Path tool support for anchor Alt-dragging to pull out a fresh equidistant handle pair Apr 14, 2025
@Keavon Keavon marked this pull request as draft April 14, 2025 06:28
@4adex 4adex marked this pull request as ready for review April 16, 2025 17:59
@Keavon
Copy link
Member

Keavon commented Apr 16, 2025

!build

Copy link

📦 Build Complete for f637c98
https://2f6e1b18.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 17, 2025

!build

Copy link

📦 Build Complete for 63ca66b
https://9cff3c83.graphite.pages.dev

@Keavon Keavon changed the title Add Path tool support for anchor Alt-dragging to pull out a fresh equidistant handle pair Add Path tool support for Alt-dragging an anchor to pull out a fresh equidistant handle pair Apr 17, 2025
@Keavon Keavon enabled auto-merge (squash) April 17, 2025 05:53
@Keavon Keavon merged commit ab39f3f into GraphiteEditor:master Apr 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants