Make the Pen tool show a path being closed by drawing a filled overlay when hovering the endpoint

[c-mateo]

Now the pen tool shows a path being closed as requested in #2390 but doesn't work well with vector meshes. The fill tool shows the region to be filled by drawing a filled overlay too. Few new methods were added to the OverlayContext for drawing paths and filling areas.

[c-mateo]

Thank you. The failed build made me notice I forgot to upload one file. Apologies.

[github-actions]

📦 Build Complete for 6e39bc2
https://3d0903e9.graphite.pages.dev

[Keavon]

pen_tool.rs requires formatting

[Keavon]

Please mark your fork as writable by maintainers of this org, since I can't push edits or even resolve conflicts in your PR. I can do a proper code review after that point. Mark this as ready for review once that's ready, thanks.

[Keavon]

Can you please try a version of the Fill tool where we use the stripes, with a fully opaque version of the fill color, drawn over what's hovered instead of the semitransparent solid version?

[c-mateo]

Like this but also filled with the primary color?

[Keavon]

Yes, but with (roughly 2x) denser stripes.

[Keavon]

It looks like you've implemented it with a fully opaque fill color + fully opaque blue stripes. My request was just for fully opaque fill color stripes.

Separately, it looks like you changed the Pen tool shape-closing opacity, can you please set that back to how I had tuned it?

[Keavon]

!build

[github-actions]

📦 Build Complete for 00866a6
https://53fe4168.graphite.pages.dev

[Keavon]

Something randomly broke while hovering over the shape and it went from showing the wide stripes to showing these very narrow stripes all of a sudden, and subsequently all stripes have been narrow after it "flipped over" randomly in that moment it occurred.

[Keavon]

Here's a video of it occurring as soon as I reload the editor and open the document and switch to the Fill tool for the first time shown in the video and simply move the mouse a little bit. This seems reproducible.

capture_57_.mp4

Here's the file (remove the .txt extension):

reproduction.graphite.txt

[c-mateo]

I can't reproduce the issue. Maybe it depends on the user's setup. For now, let's try setting the line width to a fixed value to see if it solves the issue.

[Keavon]

!build

[github-actions]

📦 Build Complete for b950441
https://39c932e8.graphite.pages.dev

[Keavon]

The shrinking lines bug is still there and pretty easy to replicate using the instructions I gave above.

[Keavon]

Looks like it happens only in Firefox.

[c-mateo]

I just downloaded Firefox 137.0.2 and don't happens to me either. Might it have anything to do with resolution, user's software or hardware?

[seam0s-dev]

I did not get to replicate the same error, instead I got this behavior on Firefox 132.0, Fedora Linux 40 Oops, I tested on the wrong commit (https://3d0903e9.graphite.pages.dev/). Ignore these videos :

2025-04-18.10-43-46.mp4

2025-04-18.10-46-49.mp4

For the correct commit, I got the same error on Firefox 132.0, Fedora Linux 40:

2025-04-18.11-19-51.mp4

2025-04-18.11-21-25.mp4

[Keavon]

Even weirder! Thanks for testing.

[Keavon]

!build

[github-actions]

📦 Build Complete for 7354586
https://38b32178.graphite.pages.dev

[Keavon]

!build

[github-actions]

📦 Build Complete for 804acfd
https://c10ac5cc.graphite.pages.dev