Skip to content

Fix Pen tool unable to combine multiple selected paths by extending their endpoints or mesh points #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 18, 2025
Merged

Fix Pen tool unable to combine multiple selected paths by extending their endpoints or mesh points #2570

merged 11 commits into from
Apr 18, 2025

Conversation

0SlowPoke0
Copy link
Contributor

@0SlowPoke0 0SlowPoke0 commented Apr 14, 2025 •
edited by Keavon
Loading

@Keavon
Copy link
Member

Keavon commented Apr 15, 2025

!build

@Keavon Keavon changed the title Fix: Pen Tool Now Extends Paths on Endpoints When Multiple Layers Selected Fix Pen tool not allowing drawing from path endpoints when multiple layers are selected Apr 15, 2025
@github-actions GitHub Actions
Copy link

📦 Build Complete for 6336ec3
https://b33a2873.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 15, 2025

Thanks, this correctly makes it possible to extend endpoints. However there's also seemingly a regression(?) where it can't be connected to an endpoint of the opposite layer.

@0SlowPoke0 0SlowPoke0 changed the title Fix Pen tool not allowing drawing from path endpoints when multiple layers are selected Fix:Pen Tool Path Drawing with Multi-Layer Selection & Add Auto-Panning for Node Graph Wire Dragging Apr 15, 2025
@Keavon Keavon changed the title Fix:Pen Tool Path Drawing with Multi-Layer Selection & Add Auto-Panning for Node Graph Wire Dragging Fix Pen tool regression where two selected paths can't be combined by their endpoints Apr 16, 2025
@Keavon
Copy link
Member

Keavon commented Apr 16, 2025

After combining the two layers, we end up with:

capture

But then after closing the two endpoints, we erroneously end up with:

capture

@Keavon Keavon marked this pull request as draft April 16, 2025 14:05
@Keavon
Copy link
Member

Keavon commented Apr 17, 2025

capture_59_.mp4

@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review April 18, 2025 05:57
@Keavon
Copy link
Member

Keavon commented Apr 18, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for ab8c33c
https://b9722dd0.graphite.pages.dev

@Keavon Keavon changed the title Fix Pen tool regression where two selected paths can't be combined by their endpoints Fix Pen tool unable to combine multiple selected paths by extending their endpoints or mesh points Apr 18, 2025
@Keavon
Copy link
Member

Keavon commented Apr 18, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for b50cf03
https://dcc9682c.graphite.pages.dev

@Keavon Keavon merged commit 33de539 into GraphiteEditor:master Apr 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0SlowPoke0 @Keavon