Add Gradient tool test for select and delete removes a stop #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
requested changes
Apr 16, 2025
Sidharth-Singh10
force-pushed
the
gradient_test3
branch
from
d995c67 to
0dbb1e9
Compare
0HyperCube
reviewed
Apr 18, 2025
Comment on lines
571
to
583
| async fn double_click_at(editor: &mut EditorTestUtils, position: DVec2) { | ||
| editor | ||
| .handle_message(InputPreprocessorMessage::DoubleClick { | ||
| editor_mouse_state: EditorMouseState { | ||
| editor_position: position, | ||
| mouse_keys: MouseKeys::LEFT, | ||
| scroll_delta: ScrollDelta::default(), | ||
| }, | ||
| modifier_keys: ModifierKeys::empty(), | ||
| }) | ||
| .await; | ||
| } |
There was a problem hiding this comment.
This looks good, however why is this not part of the EditorTestUtils like all the other testing utilities? It doesn't seem to be specific to the gradient tool.
Sidharth-Singh10
force-pushed
the
gradient_test3
branch
2 times, most recently
from
2047173 to
7b6f4f7
Compare
|
resolved conflicts |
0HyperCube
approved these changes
Apr 19, 2025
auto-merge was automatically disabled
April 19, 2025 18:45
Head branch was pushed to by a user without write access
Sidharth-Singh10
force-pushed
the
gradient_test3
branch
from
7b6f4f7 to
2798a79
Compare
|
@0HyperCube the auto-merge was disabled because there was a merge conflict again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes part of #2488