fix(ui): refine PromptDialogPane #3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Limit the dialog width to avoid too long a width - Avoid accidental blank line in the information box (That blue bg box)
burningtnt
suggested changes
Apr 4, 2025
| @@ -49,6 +49,7 @@ public class PromptDialogPane extends DialogPane { | |||
| public PromptDialogPane(Builder builder) { | |||
| this.builder = builder; | |||
| setTitle(builder.title); | |||
| setPrefWidth(560); | |||
There was a problem hiding this comment.
请避免使用魔数。可使用 org.jackhuang.hmcl.ui.Controllers#MIN_HEIGHT 的计算和 org.jackhuang.hmcl.ui.Controllers.getStage().widthProperty() 的绑定
| @@ -49,6 +49,7 @@ public class PromptDialogPane extends DialogPane { | |||
| public PromptDialogPane(Builder builder) { | |||
| this.builder = builder; | |||
| setTitle(builder.title); | |||
| setPrefWidth(560); | |||
There was a problem hiding this comment.
[nitpick] The value '560' is used directly as a magic number. Consider extracting it as a named constant or configuration parameter to enhance maintainability.
Copilot uses AI. Check for mistakes.
Glavo
approved these changes
Jun 6, 2025
|
@Glavo 为什么合并了，固定宽度真的好吗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview