Skip to content

添加Xbox封禁相关提示 #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

添加Xbox封禁相关提示 #3860

wants to merge 2 commits into from

Conversation

CiiLu
Copy link
Contributor

@CiiLu CiiLu commented Apr 26, 2025

No description provided.

@burningtnt burningtnt mentioned this pull request Apr 26, 2025
Open
burningtnt
burningtnt suggested changes May 11, 2025
View reviewed changes
Copy link
Member

@burningtnt burningtnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你只是添加了 BANNED 字段和对应的链接，但并没有在 org.jackhuang.hmcl.setting.Accounts#localizeErrorMessage 中加入对 BANNED 字段的读取和本地化逻辑。

请修改该 PR：

  • 移除常态化的“封禁查询”，这会给用户带来压迫感；
  • 添加对 BANNED 字段的读取和本地化错误信息逻辑。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burningtnt burningtnt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CiiLu @burningtnt