-
Notifications
You must be signed in to change notification settings - Fork 296
Also convert attribute units when calling convert_units
#6416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also convert attribute units when calling convert_units
#6416
Conversation
1ca463b
to
38ab31c
Compare
38ab31c
to
28dfd25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6416 +/- ##
=======================================
Coverage 89.80% 89.81%
=======================================
Files 90 90
Lines 23755 23761 +6
Branches 4418 4422 +4
=======================================
+ Hits 21334 21340 +6
Misses 1672 1672
Partials 749 749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bouweandela just one small change and then this is good to go.
🚀 Pull Request
Description
Also convert the attributes "actual_range", "valid_max", "valid_min", and "valid_range" on cubes and coordinates.
Closes #6411
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: