Skip to content

Commit 73dee61

Browse files
committed
gis-8825 cleaning
1 parent 2123434 commit 73dee61

File tree

5 files changed

+10
-22
lines changed

5 files changed

+10
-22
lines changed

uncoder-core/app/translator/core/parser.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from app.translator.core.exceptions.parser import TokenizerGeneralException
2525
from app.translator.core.functions import PlatformFunctions
2626
from app.translator.core.mapping import BasePlatformMappings, SourceMapping
27-
from app.translator.core.models.functions.base import Function, ParsedFunctions
27+
from app.translator.core.models.functions.base import Function
2828
from app.translator.core.models.platform_details import PlatformDetails
2929
from app.translator.core.models.query_container import RawQueryContainer, TokenizedQueryContainer
3030
from app.translator.core.models.query_tokens.field import Field
@@ -51,9 +51,6 @@ def parse_raw_query(self, text: str, language: str) -> RawQueryContainer:
5151
def parse(self, raw_query_container: RawQueryContainer) -> TokenizedQueryContainer:
5252
raise NotImplementedError("Abstract method")
5353

54-
def _parse_query(self, query: str) -> tuple[str, dict[str, Union[list[str], list[int]]], Optional[ParsedFunctions]]:
55-
raise NotImplementedError("Abstract method")
56-
5754

5855
class PlatformQueryParser(QueryParser, ABC):
5956
mappings: BasePlatformMappings = None
@@ -91,8 +88,3 @@ def get_source_mappings(
9188
)
9289
self.tokenizer.set_field_tokens_generic_names_map(field_tokens, source_mappings, self.mappings.default_mapping)
9390
return source_mappings
94-
95-
def get_source_mapping_ids_by_logsources(self, query: str) -> Optional[list[str]]:
96-
_, parsed_logsources, _ = self._parse_query(query=query)
97-
if parsed_logsources:
98-
return self.mappings.get_source_mappings_by_log_sources(parsed_logsources)

uncoder-core/app/translator/platforms/base/aql/parsers/aql.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"""
1818

1919
import re
20-
from typing import Optional, Union
20+
from typing import Union
2121

2222
from app.translator.core.exceptions.parser import TokenizerGeneralException
2323
from app.translator.core.models.functions.base import ParsedFunctions
@@ -105,7 +105,7 @@ def __parse_log_sources(self, query: str) -> tuple[dict[str, Union[list[str], li
105105

106106
return log_sources, query
107107

108-
def _parse_query(self, query: str) -> tuple[str, dict[str, Union[list[str], list[int]]], Optional[ParsedFunctions]]:
108+
def _parse_query(self, text: str) -> tuple[str, dict[str, Union[list[str], list[int]]], ParsedFunctions]:
109109
query = self.__clean_query(query)
110110
self.__check_table(query)
111111
query, functions = self.platform_functions.parse(query)

uncoder-core/app/translator/platforms/base/lucene/parsers/lucene.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
"""
1818

1919
import re
20-
from typing import Optional, Union
2120

22-
from app.translator.core.models.functions.base import ParsedFunctions
2321
from app.translator.core.models.query_container import RawQueryContainer, TokenizedQueryContainer
2422
from app.translator.core.parser import PlatformQueryParser
2523
from app.translator.platforms.base.lucene.tokenizer import LuceneTokenizer
@@ -33,7 +31,7 @@ class LuceneQueryParser(PlatformQueryParser):
3331

3432
wrapped_with_comment_pattern = r"^\s*//.*(?:\n|$)"
3533

36-
def _parse_query(self, query: str) -> tuple[str, dict[str, Union[list[str], list[int]]], Optional[ParsedFunctions]]:
34+
def _parse_query(self, query: str) -> tuple[str, dict[str, list[str]]]:
3735
log_sources = {}
3836
for source_type in self.log_source_key_types:
3937
pattern = self.log_source_pattern.replace("___source_type___", source_type)
@@ -45,10 +43,10 @@ def _parse_query(self, query: str) -> tuple[str, dict[str, Union[list[str], list
4543
pos_end = search.end()
4644
query = query[:pos_start] + query[pos_end:]
4745

48-
return query, log_sources, None
46+
return query, log_sources
4947

5048
def parse(self, raw_query_container: RawQueryContainer) -> TokenizedQueryContainer:
51-
query, log_sources, _ = self._parse_query(raw_query_container.query)
49+
query, log_sources = self._parse_query(raw_query_container.query)
5250
query_tokens = self.get_query_tokens(query)
5351
query_field_tokens, _, _ = self.get_field_tokens(query_tokens)
5452
source_mappings = self.get_source_mappings(query_field_tokens, log_sources)

uncoder-core/app/translator/platforms/base/sql/parsers/sql.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
"""
1818

1919
import re
20-
from typing import Optional, Union
2120

2221
from app.translator.core.models.functions.base import ParsedFunctions
2322
from app.translator.core.models.query_container import RawQueryContainer, TokenizedQueryContainer
@@ -32,18 +31,18 @@ class SqlQueryParser(PlatformQueryParser):
3231

3332
wrapped_with_comment_pattern = r"^\s*--.*(?:\n|$)"
3433

35-
def _parse_query(self, query: str) -> tuple[str, dict[str, Union[list[str], list[int]]], Optional[ParsedFunctions]]:
34+
def _parse_query(self, query: str) -> tuple[str, dict[str, list[str]]]:
3635
log_source = {"table": []}
3736
if re.search(self.query_delimiter_pattern, query, flags=re.IGNORECASE):
3837
table_search = re.search(self.table_pattern, query)
3938
table = table_search.group("table")
4039
log_source["table"] = [table]
4140
return re.split(self.query_delimiter_pattern, query, flags=re.IGNORECASE)[1], log_source, None
4241

43-
return query, log_source, None
42+
return query, log_source
4443

4544
def parse(self, raw_query_container: RawQueryContainer) -> TokenizedQueryContainer:
46-
query, log_sources, _ = self._parse_query(raw_query_container.query)
45+
query, log_sources = self._parse_query(raw_query_container.query)
4746
query_tokens = self.get_query_tokens(query)
4847
query_field_tokens, _, _ = self.get_field_tokens(query_tokens)
4948
source_mappings = self.get_source_mappings(query_field_tokens, log_sources)

uncoder-core/app/translator/platforms/microsoft/parsers/microsoft_sentinel.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
-----------------------------------------------------------------
1717
"""
1818

19-
from typing import Optional, Union
2019

2120
from app.translator.core.models.functions.base import ParsedFunctions
2221
from app.translator.core.models.platform_details import PlatformDetails
@@ -38,7 +37,7 @@ class MicrosoftSentinelQueryParser(PlatformQueryParser):
3837

3938
wrapped_with_comment_pattern = r"^\s*//.*(?:\n|$)"
4039

41-
def _parse_query(self, query: str) -> tuple[str, dict[str, Union[list[str], list[int]]], Optional[ParsedFunctions]]:
40+
def _parse_query(self, query: str) -> tuple[str, dict[str, list[str]], ParsedFunctions]:
4241
table, query, functions = self.platform_functions.parse(query)
4342
log_sources = {"table": [table]}
4443
return query, log_sources, functions

0 commit comments

Comments
 (0)