Skip to content

Commit 51407cc

Browse files
authored
Merge pull request #11564 from cmaglie/fix-url-error-handling
Gracefully handle malformed additional board manager urls
2 parents c4109e7 + 17f5719 commit 51407cc

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

arduino-core/src/cc/arduino/contributions/packages/ContributionsIndexer.java

+9-4
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,17 @@ public void parseIndex() throws Exception {
144144
index.fillCategories();
145145
}
146146

147-
private List<File> get3rdPartyIndexFiles() throws MalformedURLException {
147+
private List<File> get3rdPartyIndexFiles() {
148148
List<File> indexFiles = new ArrayList<>();
149149
for (String urlString : PreferencesData.getCollection(Constants.PREF_BOARDS_MANAGER_ADDITIONAL_URLS)) {
150-
final URL url = new URL(urlString);
151-
String filename = FilenameUtils.getName(url.getPath());
152-
indexFiles.add(getIndexFile(filename));
150+
URL url;
151+
try {
152+
url = new URL(urlString);
153+
String filename = FilenameUtils.getName(url.getPath());
154+
indexFiles.add(getIndexFile(filename));
155+
} catch (MalformedURLException e) {
156+
System.err.println(format(tr("Malformed Additional Board Manager URL '{0}': {1}"), urlString, e.getMessage()));
157+
}
153158
}
154159

155160
File[] testIndexFiles = preferencesFolder.listFiles((dir, name) -> {

0 commit comments

Comments
 (0)