Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes on tests and github actions runner for Windows #10196

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Bugfixes on tests and github actions runner for Windows #10196

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
122ad00
Fix "illegal char" in build.xml
cmaglie Apr 4, 2020
223a6a1
Rename unit-test gh action
cmaglie Apr 4, 2020
4a5e304
Run tests without creating 'dist'
cmaglie Apr 4, 2020
6cb1625
Added windows testing
cmaglie Apr 4, 2020
941363c
Always publish results
cmaglie May 11, 2020
7852fc1
prevent CRLF poisoning of data file for unit tests
cmaglie Apr 5, 2020
720b7a9
Fixed JSONDownloader tests on Windows
cmaglie Apr 5, 2020
24bf3eb
Fixed SerialTest on Windows
cmaglie Apr 5, 2020
a6ef343
Fixed CommandLineTests for Windows
cmaglie May 11, 2020
ac3d1fe
Put require .dll together with work/java/bin/java
cmaglie Apr 7, 2020
74a66e5
Replaced FEST with assertJ
cmaglie Apr 7, 2020
5e9d0cc
Print details for failed tests
cmaglie Apr 5, 2020
ef5d316
Explicitly pass output stream in runArduino(..) test function
cmaglie May 12, 2020
ea25c35
Fixed EditorConsoleTest on Windows
cmaglie Jun 19, 2020
1621776
test: gather all output before going on with tests
cmaglie Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed SerialTest on Windows 
It looks like that on Windows string builders use a default encoding that
is different from UTF-8.
  • Loading branch information
@cmaglie
cmaglie committed Jun 19, 2020
commit 24bf3eb348dcc31763de6919173b69ec2ced6c77
14 changes: 11 additions & 3 deletions app/test/processing/app/SerialTest.java
View file
Original file line number Diff line number Diff line change
@@ -51,8 +51,16 @@ protected void message(char[] chars, int length) {
public void testSerialUTF8Decoder() throws Exception {
NullSerial s = new NullSerial();
// https://github.com/arduino/Arduino/issues/9808
String testdata = "012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789°0123456789";
s.processSerialEvent(testdata.getBytes());
assertEquals(s.output, testdata);
byte testData[] = { 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 48, 49, 50, 51,
52, 53, 54, 55, 56, 57, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 48, 49,
50, 51, 52, 53, 54, 55, 56, 57, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57,
48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 48, 49, 50, 51, 52, 53, 54, 55,
56, 57, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 48, 49, 50, 51, 52, 53,
54, 55, 56, 57, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 48, 49, 50, 51,
52, 53, 54, 55, 56, 57, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, //
-62, -80, // UTF8 char
48, 49, 50, 51, 52, 53, 54, 55, 56, 57 };
s.processSerialEvent(testData);
assertEquals(new String(testData, "UTF-8"), s.output);
}
}