Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow install Theme from Preferences dialog #10202

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Allow install Theme from Preferences dialog #10202

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cd2e7c
Allow install Theme from Preferences dialog
ricardojlrufino May 13, 2020
4007b84
handle invalid themes
ricardojlrufino May 13, 2020
c906806
Avoid error on save, if canceled theme instalation
ricardojlrufino May 14, 2020
0ec01c3
(Codacy fix) Avoid unused imports
ricardojlrufino May 14, 2020
459d7a3
(Codacy fix) Avoid unused imports
ricardojlrufino May 14, 2020
703c176
Merge branch 'pr-install-theme' of https://github.com/ricardojlrufino…
ricardojlrufino May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid error on save, if canceled theme instalation
  • Loading branch information
@ricardojlrufino
ricardojlrufino committed May 14, 2020
commit c906806a4727afee376bfb6cee700566283a42c2
5 changes: 4 additions & 1 deletion app/src/cc/arduino/view/preferences/Preferences.java
View file
Original file line number Diff line number Diff line change
@@ -798,7 +798,10 @@ private void savePreferencesData() {
if (comboTheme.getSelectedIndex() == 0) {
PreferencesData.set("theme.file", "");
} else {
PreferencesData.set("theme.file", ((ZippedTheme) comboTheme.getSelectedItem()).getKey());
Object selectedItem = comboTheme.getSelectedItem();
if(selectedItem instanceof ZippedTheme) {
PreferencesData.set("theme.file", ((ZippedTheme) selectedItem).getKey());
}
}

String newSizeText = fontSizeField.getText();