Fixes to UDP so that it no longer has socket 0 hardcoded - all part of issue #436 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te read). This one moves all of the checking into recv, so that single-byte reads also benefit. It also returns -1 if there's no data available unless we've reached EOF, in which case it returns 0.
…e the corrent return values. This should have been in the previous commit, but I'm still getting my head round git.
|
On a quick review, these changes look reasonable. I'll take a closer look and apply them when I get a chance. BTW, it's helpful to have separate pull requests for different issues (e.g. UDP changes vs. addition of read(buf, len)). I wouldn't necessarily worry about it here, but it will make things easier going forward. I think it requires the use of separate branches, which is a bit annoying, but luckily git makes it easy to merge changes between them. |
|
Agreed. I wanted to push them through as separate pull requests, but couldn't work out how to have github do that. Will have a look into the separate branch approach for future changes. |
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
Updated led_remote example to use correct var on line 172
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UdpClass::begin now finds the first available free socket, or fails if they're all in use.
UdpClass::stop added to release the socket once it is no longer needed.
The global Udp object has also been removed and the examples updated to provide their own instance.
Finally, in testing I noticed that the UdpNtpClient didn't print leading 0s if the minute or second was a single-digit, so have taken the opportunity to provide a simple fix for it.