Skip to content

add optional timeout parameter -t #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
Merged

add optional timeout parameter -t #13

merged 1 commit into from
Jan 10, 2022

Conversation

JAndrassy
Copy link
Contributor

For some uploads 10 seconds is not enough.

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2022

CLA assistant check
All committers have signed the CLA.

For some uploads 10 seconds is not enough.
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Jan 5, 2022
@JAndrassy
Copy link
Contributor Author

JAndrassy commented Jan 5, 2022

some context: I developed further the WiFi101_OTA library as a generic ArduinoOTA library. The library is used even with platforms without arduinoOTA configured so the library provides platform.local.txt for supported platforms. Here the users can simply add the new timeout parameter. Additionally the platform.local.txt have arduinoOTA configured as a programmer so user can add a 'programmer' with fixed IP address in programmers.txt. The timeout parameter can then be configured for specific IP address that is specific device.

@facchinm facchinm merged commit 3a2c9c9 into arduino:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants