Clean up dependencies installation symlinks on exit #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code used to install Arduino CLI, platform, and library dependencies does this by creating symlinks in the appropriate locations on the runner. The files the script gathers via clone or download, are stored in a temporary folder that is deleted when the script exits. This means the installation symlink for those files has no possible use after the script finishes. This particular pollution of the runner's environment is resolved by also registering a call to delete on exit as each symlink is created.
per1234
added
type: imperfection
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 1596 1598 +2
=========================================
+ Hits 1596 1598 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to install Arduino CLI, platform, and library dependencies does so by creating symlinks in the appropriate locations on the runner. The files the script gathers via clone or download, are stored in a temporary folder that is deleted when the script exits. This means the installation symlink for those files has no possible use after the script finishes.
This particular pollution of the runner's environment is resolved by also registering a call to delete on exit as each symlink is created.