-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Components v2: use valid JSON examples #7535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd assume it was done that way to show that it belongs in payload's component field, but that isn't the main bit being demonstrated in the example. These updated ones are now showing examples of the full payload_json but are missing the component v2 flag, so if anything I think these are more wrong based on that. If it were to change, I think it'd make most sense to remove the |
@leymbda I think changing the examples just to show the inside of the components array makes the most sense here. I now understand what he was trying to do with the partial, but just having the dangling |
Yeah I was just trying to show as much as I thought was necessary without taking up too much space. I do think yall are right though that this should either contain the flag or just be the components array. I feel like adding the flag is the way to go since we want all our samples to use that going forward. What do you think? |
@anthonydiscord yeah, that's fine. i've updated it to include the full json object with the message flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thank you for thinking through this!
* fix(components): use valid JSON examples * components v2: use inner components array for json examples * components v2: fix json examples
None of these components have proper JSON examples. I'm not sure why, but I'm assuming it's not intentional.