-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add caveat for allowed_mentions in interactions #7629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll take it for a spin tomorrow just to preview the changes, but assuming no issue there, this is good to merge.
Thanks for the expanded update!
"allowed_mentions": { | ||
"users": ["123", "125"] | ||
"users": ["123", "456"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this change to the numbers not being so close 👍🏻
oh no, markdown formatting issue! 😱
If you run |
a single space on each line caused this haha, should be fixed now though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Co-authored-by: Mark Mandel <mark@compoundtheory.com>
are codeblocks supposed to render with two tones of black? |
Yeah, they've been doing that lately. Something got updated - at some point we'll go find out what it was. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
* add caveat for allowed mentions in interactions * deeper rewrite of allowed mentions docs 🤠 * red ping -> notification * Update message.mdx * fix spaces * Update docs/resources/message.mdx Co-authored-by: Mark Mandel <mark@compoundtheory.com> * Update docs/resources/message.mdx Co-authored-by: Mark Mandel <mark@compoundtheory.com> --------- Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Adds documentation for this change from 2021 which somehow never made it to the docs