generated from discourse/discourse-plugin-skeleton
-
Notifications
You must be signed in to change notification settings - Fork 42
FEATURE: configure a default LLM model for all features #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keegangeorge
wants to merge
31
commits into
main
Choose a base branch
from
default-llm-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+629
β391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds a setting to the configure a default LLM model to be used for all features (unless overridden).
- no need for seeding checks or module dependant checks
It resets it to default before the migration
romanrizzi
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do ai_translation_model
too?
db/migrate/20250710181656_copy_ai_helper_model_to_persona_default.rb
Outdated
Show resolved
Hide resolved
and update migrations for translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Overview
This update adds a setting to the configure a default LLM model to be used for all features (unless overridden) and removes the
custom:
prefix when defining LLM modelsβ More information
For all features, the feature's assigned AI Persona's
default_llm_id
will be used, however, if it doesn't exist, theSiteSetting.ai_default_llm_model
will be used instead.This update also adds a few migrations which migrates the old model settings for Helper and Summarization into their respective personas. That is:
SiteSetting.ai_helper_model
's existing value on sites will be copied into:SiteSetting.ai_summarization_model
's existing value on sites will be copied intoEventually, we will follow-up in a separate commit to remove the following settings:
By default
SiteSetting.ai_default_llm_model
will havedefault: ""
in it'syaml
file, however, this update also adds a migration which will ensure that the last created LLM model is used to fill the setting.πΈ Screenshots