Feature/metabase 48 #21
Conversation
|
Thank you for your hard work 👏 This breaks FIRST and SKIP implementation in apply-top-level-clause: Could you please look into possible workaround? |
|
Hey @mat02
thanks for that link!
That changes were not mentioned in die Metabase Upgrade docs, so I missed them - I will look into that!
Still, I find it weird that the driver is working fine for us and only some people are experiencing problems...
Best
Nikos
-------- Original-Nachricht --------
Am 7. März 2024, 11:25, schrieb Mateusz Knapik :
… Thank you for your hard work 👏
It looks like change to HSQL 2 brought some more breaking changes, i.e. :modifiers not longer exists:
https://github.com/seancorfield/honeysql/blob/7a7a01eeaaa56b6e00574feb63be9c09e782f2c2/doc/differences-from-1-x.md?plain=1#L166
This breaks FIRST and SKIP implementation in apply-top-level-clause:
https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L83
https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L86
Could you please look into possible workaround?
—
Reply to this email directly, [view it on GitHub](#21 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AE7I4UROFJR6G5IPTCV2KKLYXA6CBAVCNFSM6AAAAABB42TGNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGIYDGNBRGE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Maybe this is related to the FB version. We run 3.0 in SuperServer mode (I believe this is the same as you are, at least I think I saw it mentioned somewhere), but only stumbled on this problem with :modifiers keyword in in some specific questions, where Metabase automatically applies top-level clause to limit number of rows (not exactly sure why. Unfortunately, I am not familiar with Clojure (nor other functional languages) enough to fix this myself :/ |
|
@Nikos410 @mat02 I have spent the last 2 days testing with the latest Jaybird 6.0.1 and updated this feature to actually connect to a firebird databse (3.0 >). I am busy testing all the features , basic things like table layouts and schema not working yet but will keep testing and working on it. Testing with Metabase v0.54. Normal SQL is working for reporting. |
|
any updates? |
|
Still working through thing, biggest blocker is my lack of clojure knowledge.. I have metabase working with normal SQL queries now and have it actually displaying things for one of our products. will update again when I have a "production" ready version. If you need connectivity urgently, I think a pull off my latest branch will work ... let me know if you need me to post a jar file. |
|
I've made a pull request, so far seems most things are working, please send me feedback, I've made a release here in the mean time |
|
Thanks a lot for your help! 🙌 If possible, it would be great to have an option to add parameters to the JDBC connection string, since here we use |
|
Can you send me some examples , would it be possible for me to send you an
invite to my Slack or teams to collaborate?
[image: http://www.daniweb.com/profiles/1108517/Andre-van-Zuydam]
<http://www.daniweb.com/profiles/1108517/Andre-van-Zuydam>
[image: https://www.openhub.net/accounts/75973?ref=Detailed]
<https://www.openhub.net/accounts/75973?ref=Detailed>
…On Thu, 28 Aug 2025 at 14:48, Luiz Fernando Trevisan < ***@***.***> wrote:
*luiz-limber* left a comment (evosec/metabase-firebird-driver#21)
<#21 (comment)>
Thanks a lot for your help! 🙌
I tested it with Metabase v56 and the connection + SQL queries are working
very well.
I’m using Firebird 5.0 and, for now, I’m only running parameterized SQL
queries.
If possible, it would be great to have an option to add parameters to the
JDBC connection string, since here we use encoding=iso8859_1 for
compatibility with accented characters.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOR7HPNUO2KNVTDQZK2MLL3P33BNAVCNFSM6AAAAAB6E4OJLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMZTGM3DQMRWG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
There are a number of bugs with date transformations which I am fixing, I have added in the JDBC connection string functionality, I'm going to log issues on my fork and you can follow it there |
|
@luiz-limber Check latest release, feature as you requested is in and all the obvious bugs I found should be fixed. |
No description provided.