fix: small UI bug in robotic arm screen

[rahul31124]

Changes

Fixed a UI bug where duty cycle (%) was not aligning correctly if null values existed before. Resolved the issue by using a map to track and render percentages only for valid spots

Before

After

Checklist:

• No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
• No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
• Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
• No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Bug Fixes:

• Align duty cycle labels correctly by replacing inline dutyList calculations with a precomputed list of valid label points supplied by the state provider.

[sourcery-ai]

Reviewer's Guide

This PR addresses a UI misalignment in the robotic arm duty cycle display by precomputing label positions and texts in the state provider and updating the chart widget to render only valid percentage labels from that precomputed list.

Class diagram for updated RoboticArmStateProvider and data flow

classDiagram
    class RoboticArmStateProvider {
      +List<FlSpot> spots
      +List<double> dutyCycles
      +List<double> angleList
      +List<Map<String, dynamic>> dutyLabelPoints
      +Map<String, dynamic> getSummaryData()
    }
    class PlaybackSummaryDialog {
      +build()
    }
    RoboticArmStateProvider <|-- PlaybackSummaryDialog : provides data
    RoboticArmStateProvider : +dutyLabelPoints
    PlaybackSummaryDialog : +labelPoints

Loading

File-Level Changes

Change	Details	Files
Precompute duty cycle label points in the state provider	Declared a new dutyLabelPoints list to hold x positions and formatted labels Calculated midpoint (x) and label for each duty cycle during data assembly Appended map entries with 'x' and 'label' to dutyLabelPoints Included dutyLabelPoints in the returned summary data map	lib/providers/robotic_arm_state_provider.dart
Render duty cycle labels from precomputed points in the UI widget	Introduced labelPoints variable from incoming data Removed manual period and dutyList traversal logic Added guard to return empty widget when no valid spots exist Looped through labelPoints to match axis values and render Text(label) Retained fallback to SizedBox.shrink() for unmatched positions	lib/view/widgets/robotic_arm_summary.dart

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

• Replace the undefined pwmSpots check in getTitlesWidget with a check on labelPoints to avoid referencing an incorrect variable.
• Clear or reinitialize the dutyLabelPoints list at the start of each data calculation (or scope it locally) to prevent accumulating stale entries across updates.
• Consider creating a small data class for duty label points instead of using Map<String, dynamic> to improve type safety and readability.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Replace the undefined `pwmSpots` check in `getTitlesWidget` with a check on `labelPoints` to avoid referencing an incorrect variable.
- Clear or reinitialize the `dutyLabelPoints` list at the start of each data calculation (or scope it locally) to prevent accumulating stale entries across updates.
- Consider creating a small data class for duty label points instead of using `Map<String, dynamic>` to improve type safety and readability.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/16052363193/artifacts/3458718896