Enable docker builds with shell using different dockerfile #639
+29
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to enabling shell access in our Docker image for developers that wish to use an image with a distro, this adds
Dockerfile-with-shell
to the repository root and can be run like so:docker build --file Dockerfile-with-shell . --tag ghcr.io/github/github-mcp-server:sh docker run --rm -it --entrypoint /bin/sh ghcr.io/github/github-mcp-server:sh
In future we could consider letting this be a later build stage in our main Dockerfile and for our releases use the specific distroless build stage, while enabling others to build with a distro by default which is more common.
Motivation: #574
Docker's custom override: dgageot@2e73e0a
The Docker MCP Hub listing that points to unsanctioned (by GitHub) fork: https://hub.docker.com/r/mcp/github-mcp-server
CC @dgageot