Set default shareEnabled to true #1035
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It seems like this was accidentally introduced in some UI fixes (graphql@273697e#diff-de99fb113c90fc40c0f1349bddf05b09) - The PR (graphql#642) that added shareEnabled set default to true - Resolves graphql#983
|
@zhammer one question, could be possible to achieve this right now from |
|
can this get a review and merged? It would be great to have a fix, or at the very least add this setting to the settings object |
|
i'll try sharing in the prisma gitter chat |
|
Is it possible to enable sharing manually from a GraphQL playground? |
|
not being able to share from both the hosted website and local application defeats the whole purpose of |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this was accidentally introduced in some UI fixes (273697e#diff-de99fb113c90fc40c0f1349bddf05b09)
The PR (#642) that added shareEnabled set default to true
Fixes #983
Changes proposed in this pull request:
shareEnableddefaults to true