Skip to content

fix(#1247): Added subscriptionEndpointConnectionTimeout option #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fiLLLip
Copy link

@fiLLLip fiLLLip commented Sep 30, 2020

Forcing timeout to be set value by setting both timeout and minTimeout on the subscription client

Fixes #1247.

Changes proposed in this pull request:

  • Add new setting/property subscriptionEndpointConnectionTimeout

Forcing timeout to be set value by setting both timeout and minTimeout on the subscription client
@acao
Copy link
Member

acao commented Oct 20, 2020

@fiLLLip thanks for this! it looks like your PR just so happened to clash with one we just merged for global session headers. can you handle this merge conflict now?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@brianwarner
Copy link
Contributor

FYI, you can ignore the CLAassistant comment. I've disabled it for this repo since we use EasyCLA now.

@fiLLLip
Copy link
Author

fiLLLip commented Feb 22, 2021

I did not notice your comment, @acao. I'll try to get around and check it.

@brianwarner I was just about to comment it! Is that something I have so sign?

@brianwarner
Copy link
Contributor

Yeah, the EasyCLA bot should run when you push your next commit and prompt you to sign the current documents. This one was just out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set subscription timeout via config
4 participants