-
Notifications
You must be signed in to change notification settings - Fork 738
Use graphql ws instead of subscriptions-transport-ws #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Any traction on this PR? |
|
FYI, you can ignore the CLAassistant comment. I've disabled it for this repo since we use EasyCLA now. |
So is there anything I can do to get this merged? |
@ardatan this is a tricky one, since this will "break" legacy protocol support which has been an issue with |
Can't wait for this PR to merge!! Any updates? |
@skk2142 see the comment above; just waiting for the PR to be updated for legacy support! |
hello guys, I had some time so I made a PR for this 1326 |
Any updates? |
Ideally, the subscription client API should be a pluggable API. The |
Any updates? |
this package is better maintained than subscriptions-transport-ws and has an esm version however, it will not work with graphql-playground until graphql/graphql-playground#1295 lands
I badly need graphql-ws support in Playground. @ardatan I tried using your repo
but am getting many versioning issues. Posted here as no issues or discussion on the fork.
|
@AaronNGray i ended up switching to altair https://github.com/altair-graphql/altair it works well and supports planning to eventually switch to graphiql 2.0, looks like it'll be a while. |
@ardatan I just merged another PR that does this my bad, perhaps you'd like to follow up with a new PR? |
Would it be possible to publish to npm the changes you merged please? It might fix most of the issues people are reporting in issues and in this PR |
subscriptions-transport-ws
has been deprecated in favor ofgraphql-ws
. This PR replacesgraphql-ws
withsubscriptions-transport-ws
apollographql/subscriptions-transport-ws@76d9777