feat(select): add close button text property #30282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new property to customize the close button in the select when the interface is Modal.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
niconaso
changed the title
|
Thank you for submitting the PR! Please create an issue for this. We'd like to understand the use case for this feature before we expose this API. Thanks! |
ionitron-bot
bot
added
triage
and removed
needs: reply
luisbytes
reviewed
Apr 8, 2025
| @@ -724,6 +724,7 @@ export class Select implements ComponentInterface { | |||
| component: 'ion-select-modal', | |||
| componentProps: { | |||
| header: interfaceOptions.header, | |||
| closeText: interfaceOptions.closeText, | |||
There was a problem hiding this comment.
cancelText: this.cancelText,
I consider better to use the existing property cancelText, instead of creating a new one, so we avoid having two properties for the same thing.
There was a problem hiding this comment.
I agree with you @luisbytes. Thanks for letting me know.
I'll change it and push the changes today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30295
What is the new behavior?
Does this introduce a breaking change?