feat(css): add support for the subtle color map #30306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
Apr 3, 2025
brandyscarney
commented
Apr 3, 2025
BenOsodrac
approved these changes
Apr 9, 2025
thetaPC
reviewed
Apr 9, 2025
thetaPC
reviewed
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The colors are only available in bold colors.
What is the new behavior?
Adds support for a
subtlehue to the colors map, generating all of the same variants but in more subtle colors. This only applies for theionictheme. Adds an additional variant,foregroundto be used by components when the color is being used for text.The
iosandmdthemes do not add theforegroundvariant because this would be a breaking change, requiring all color overrides, palettes, and new colors to include this variant. I have added tests to make sure they still work without it.Does this introduce a breaking change?
No changes are made to the existing colors.
Other information
Preview