Skip to content

Ensure subject is completed when unsubscribed #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented May 12, 2025

Make it more obvious and fail safe that the devicechange listener gets removed once the observable is being unsubscribed

Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 8693f8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/components-core Patch
@livekit/components-react Patch
@livekit/component-example-next Patch
@livekit/components-js-docs Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from bcherry May 12, 2025 13:12
Copy link
Contributor

github-actions bot commented May 12, 2025

size-limit report 📦

Path Size
LiveKitRoom only 5.98 KB (0%)
LiveKitRoom with VideoConference 30.38 KB (-0.14% 🔽)
All exports 37.64 KB (+0.07% 🔺)

@lukasIO lukasIO merged commit 0854fe1 into main May 13, 2025
6 checks passed
@lukasIO lukasIO deleted the lukas/observable-cleanup branch May 13, 2025 05:10
@github-actions github-actions bot mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants