RUST-2080 spec tests (and fix) for gridfs rename #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
force-pushed
the
RUST-2080/gridfs-rename-tests
branch
from
0a99647 to
8c0dc9f
Compare
isabelatkinson
approved these changes
Apr 30, 2025
Comment on lines
+57
to
+62
| let cmd = doc! { | ||
| "renameCollection": crate::bson::to_bson(&ns)?, | ||
| "to": crate::bson::to_bson(&to_ns)?, | ||
| }; | ||
| let admin = test_runner.internal_client.database("admin"); | ||
| admin.run_command(cmd).await?; |
There was a problem hiding this comment.
I think we could technically drop support for this operation and skip tests that use it since it's not part of our API. That said, I can't think of a good reason to reduce test coverage here so probably fine to leave as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2080
This syncs the tests and adds the missing file-not-found logic that the tests caught.
This did require making the
renametest operation a little odd because it can either target a collection, in which case it accepts arguments of the form{ to: String }, or it can target a gridfs bucket, where the arguments are{ id: Bson, newFilename: String }. We parse the test file json intoTestOperationvalues at file load time, where entity type isn't known, so we can't have distinct operation types for "rename collection" and "rename bucket", so instead there's now a wrapper layer that defers parsing the args document until the test is actually executed at which point it checks entity type and parses appropriately.