-
Notifications
You must be signed in to change notification settings - Fork 1
allow set max number of logs to collect #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pana1990
wants to merge
2
commits into
main
Choose a base branch
from
8-allow-set-max-number-of-logs-to-collect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,8 @@ | ||
on: [push, pull_request] | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
|
||
name: Lint | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace WebProfiler\Traits; | ||
|
||
trait BufferSize | ||
{ | ||
private ?int $bufferSize = null; | ||
|
||
public function isBufferSizeExceeded(): bool | ||
{ | ||
return $this->bufferSize < memory_get_usage(); | ||
} | ||
|
||
public function setBufferSize(int $bufferSize): void | ||
{ | ||
$this->bufferSize = $bufferSize; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diría que aquí se están justando 2 conceptos. Por un lado el uso de memoria de la aplicación y por otro el uso de memoria de los traceables.
La comparación no creo que debería ser con
memory_get_usage
si no con el tamaño que internamente tenga guardado el traceable.Esto último haría que cada traceable tuviera su propio buffer, que quizá individualmente no llegan al máximo pero en conjunto sí.
Por eso creo que la solución buena sería más bien una clase por encima que vaya haciendo la gestión de las trazas que se guaran en memoria. Al tener todas podría saber el tamaño real que está consumiendo todo lo relacionado con logs (y sin depender de memory_get_usage y por tanto del resto de uso que está teniendo la aplicación).
El tener una clase por encima además permitiría guardar las trazas de otra manera que no fuera en memoria o incluso cuando llegue al límite en vez de dejar de logear enviar al Storage lo que tenga actualmente.
A su vez esto podría provocar que durante la ejecución funcionara bien pero a la hora de leer el json del storage fuera mal por límite máximo de memoria. Aquí la solución sería establecer un límite máximo de logs (en vez de de buffer, porque se va a ir volcando) o directamente mejorar el parseo del json para que quepa en memoria (quizá esto tiene demasiadas implicaciones y sería para otra versión).
Esto sería un cambio más grande de infraestructura de la librería.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Seldaek/monolog/blob/main/src/Monolog/Handler/BufferHandler.php