Skip to content

fix(OIDC): preserve existing OAuth user roles instead of resetting to default #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

fix(OIDC): preserve existing OAuth user roles instead of resetting to default #1356

merged 2 commits into from
Jun 24, 2025

Conversation

vkhinvasara
Copy link
Contributor

@vkhinvasara vkhinvasara commented Jun 23, 2025 •
edited by coderabbitai bot
Loading

fix: preserve existing OAuth user roles instead of resetting to default

  • Modified reply_login function to check for existing users before role assignment
  • Existing OAuth users now retain their current roles when OIDC provider doesn't return valid groups
  • Only new users get assigned default roles when no valid groups are provided
  • Fixes issue where existing OAuth users had their roles reset on every login

Summary by CodeRabbit

  • Bug Fixes
    • Improved user role assignment to ensure existing users retain their current roles when group information is missing or unrecognized.
    • Reduced redundant user lookups during authentication, resulting in more consistent and efficient user updates.

@vkhinvasara
fix: preserve existing OAuth user roles instead of resetting to default
70ba7df 
- Modified reply_login function to check for existing users before role assignment
- Existing OAuth users now retain their current roles when OIDC provider doesn't return valid groups
- Only new users get assigned default roles when no valid groups are provided
- Fixes issue where existing OAuth users had their roles reset on every login
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 23, 2025 •
edited
Loading

Walkthrough

The code in the OIDC HTTP handler has been updated to optimize user retrieval and role assignment logic. It now fetches the existing user once, preserves roles for existing users with no matching groups, and ensures only new users receive the default role. Duplicate user retrievals have been eliminated.

Changes

File(s) Change Summary
src/handlers/http/oidc.rs Optimized user retrieval, updated conditional role assignment to preserve roles for existing users, and removed redundant lookups.

Suggested reviewers

  • nikhilsinhaparseable

Poem

In the warren of code, we hop and refine,
Fetching each user just one single time.
Roles now preserved, no defaults misplaced,
New bunnies get roles, old ones embraced.
Cleaner, quicker, less to repeat—
These handler changes sure are neat! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70ba7df and b155f6e.

📒 Files selected for processing (1)
  • src/handlers/http/oidc.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/handlers/http/oidc.rs
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: coverage
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vkhinvasara vkhinvasara requested a review from parmesant June 23, 2025 23:05
@vkhinvasara vkhinvasara self-assigned this Jun 23, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Jun 23, 2025
View reviewed changes
@vkhinvasara vkhinvasara changed the title fix: preserve existing OAuth user roles instead of resetting to default fix(OIDC): preserve existing OAuth user roles instead of resetting to default Jun 23, 2025
nikhilsinhaparseable
nikhilsinhaparseable approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@nitisht nitisht merged commit ca37efd into parseablehq:main Jun 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@parmesant parmesant Awaiting requested review from parmesant

Assignees

@vkhinvasara vkhinvasara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkhinvasara @nikhilsinhaparseable @nitisht