Skip to content

Use the default 15-seconds TCP-Keepalive #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tahajahangir
Copy link

This reverts commit 4bf8b5a

TCP-Keepalives are enable by default in go since go 1.12 in this commit few months after #825 were merged.

Now the default value of 15-seconds is better and safer and we can remove this.

tahajahangir and others added 2 commits June 3, 2024 08:06
This reverts commit 4bf8b5a
The default interval for TCP health probes is 15-seconds
@ndyakov ndyakov self-requested a review March 19, 2025 12:41
@ndyakov ndyakov self-assigned this Mar 19, 2025
@ndyakov
Copy link
Member

ndyakov commented Apr 22, 2025

@tahajahangir the default KeepAlive interval is too short and will increase cpu usage. I would prefer to wait to update to go1.23+ to include golang/go#62254 and have a finer grain configuration. Maybe a longer initial interval and then shorter intervals will work good with go-redis.

@ndyakov ndyakov closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants